-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Update exemplars with latest SDK changes #1689
Merged
vishweshbankwar
merged 16 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/update-exemplars
Apr 26, 2024
Merged
[Exporter.Geneva] Update exemplars with latest SDK changes #1689
vishweshbankwar
merged 16 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/update-exemplars
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
+ Coverage 73.91% 75.51% +1.59%
==========================================
Files 267 269 +2
Lines 9615 10251 +636
==========================================
+ Hits 7107 7741 +634
- Misses 2508 2510 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodeBlanch
reviewed
Apr 24, 2024
utpilla
reviewed
Apr 25, 2024
utpilla
reviewed
Apr 25, 2024
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
utpilla
reviewed
Apr 25, 2024
test/OpenTelemetry.Exporter.Geneva.Benchmark/Exporter/MetricExporterBenchmarks.cs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
Apr 25, 2024
Received approval from component owner for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Updates TLV serialization with latest changes on SDK side for exemplars. Also updating the SDK reference to
1.8.0-rc.1
.Will do
1.8.0-rc.1
release of exporter with these changes. Would unlist1.8.0-beta.1
version as that prevents users to use exemplars due to dependency on1.8.1
version of SDK.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes