Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Update exemplars with latest SDK changes #1689

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 24, 2024

Fixes #.

Changes

Updates TLV serialization with latest changes on SDK side for exemplars. Also updating the SDK reference to 1.8.0-rc.1 .

Will do 1.8.0-rc.1 release of exporter with these changes. Would unlist 1.8.0-beta.1 version as that prevents users to use exemplars due to dependency on 1.8.1 version of SDK.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (71655ce) to head (736ee78).
Report is 219 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
+ Coverage   73.91%   75.51%   +1.59%     
==========================================
  Files         267      269       +2     
  Lines        9615    10251     +636     
==========================================
+ Hits         7107     7741     +634     
- Misses       2508     2510       +2     
Flag Coverage Δ
unittests-Exporter.Geneva 63.66% <100.00%> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 82.75% <ø> (?)
unittests-Instrumentation.AspNet 77.11% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...metry.Exporter.Geneva/Metrics/TlvMetricExporter.cs 78.48% <100.00%> (ø)

... and 229 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 24, 2024 19:58
@vishweshbankwar vishweshbankwar requested a review from a team April 24, 2024 19:58
@vishweshbankwar vishweshbankwar merged commit df77cbb into open-telemetry:main Apr 26, 2024
126 checks passed
@vishweshbankwar
Copy link
Member Author

Received approval from component owner for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants