Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva][otlp protobuf] Add support for Gauge #1634

Conversation

vishweshbankwar
Copy link
Member

Towards #1585

Changes

Support for Gauge instruments and refactoring to use common method for serializing datapoints.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.01%. Comparing base (71655ce) to head (6ad8c79).
Report is 176 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1634       +/-   ##
===========================================
- Coverage   73.91%   60.01%   -13.91%     
===========================================
  Files         267       35      -232     
  Lines        9615     3381     -6234     
===========================================
- Hits         7107     2029     -5078     
+ Misses       2508     1352     -1156     
Flag Coverage Δ
unittests-Exporter.Geneva 60.01% <90.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 88.29% <90.00%> (ø)

... and 243 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 2, 2024 20:04
@vishweshbankwar vishweshbankwar requested a review from a team April 2, 2024 20:04
@utpilla utpilla changed the title []Exporter.Geneva][otlp protobuf] Add support for Gauge [Exporter.Geneva][otlp protobuf] Add support for Gauge Apr 2, 2024
@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Apr 2, 2024
@vishweshbankwar vishweshbankwar merged commit fb7cdba into open-telemetry:main Apr 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants