-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Business Metric Service #852
Add Business Metric Service #852
Conversation
Are we adding a new java service? |
I'm hesitant to add to the existing resource requirements given the kubecon feedback for a smaller footprint |
same here |
I don't anticipate this being used in a local deployment -- my 0.02 is that we should address the resource issue by creating a "minimal" set of services to be run locally while allowing for a larger set to be run in "production" deployments |
The advantage of adding a net new service here is that it's a terminal/leaf service, ensuring that disabling the service or running it without instrumentation doesn't impact the rest of the deployment. |
Let's create a plan to have minimal and more expansive deployment scenarios before we add anything new. Something we can discuss in detail at the next SIG meeting. |
Can merge post simple+ demo |
FYI I'm building this in my own repo and publishing it in the meantime - https://github.com/austinlparker/otel-demo-business-metrics |
I'll be able to publicly share the demo flow for this in a few weeks |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
After we get #872 finished and merged, we can look to move this as an additional service in an optional module/preset. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Changes
Closes #850
This adds a Java service that deliberately does not enable OpenTelemetry instrumentation at build time. It only takes a dependency on the OpenTelemetry API to create a metric. The intended use of this service is to demonstrate the OpenTelemetry Operator's Instrumentation CRDs (as well as API-only usage of OpenTelemetry).
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.