-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[collector] use spanmetrics connector instead of spanmetrics processor #829
[collector] use spanmetrics connector instead of spanmetrics processor #829
Conversation
Assuming this is outdated: https://github.com/open-telemetry/opentelemetry-collector/blob/main/connector/README.md#status If the @austinlparker, you have mentioned that the README was probably outdated, right? |
@fatsheep9146 could you also add a changelog? |
Done |
Signed-off-by: Ziqi Zhao <[email protected]>
bdee019
to
92543a7
Compare
I think this also makes sense. But I just want to experience with this useful feature, since the |
I had some personal issues with beta releases b4 😅 . I'm good to go either way, just want to hear from everyone first. |
Given the cadence of collector releases and how quickly things move thru maturity phases, I'd argue that we should pick up connectors now in order to get useful feedback for collector devs? |
…metry#829) Signed-off-by: Ziqi Zhao <[email protected]>
…metry#829) Signed-off-by: Ziqi Zhao <[email protected]>
Changes
I would suggest updating opentelemetry-demo to use the spanmetrics connector instead of the spanmetrics processor, as the latter has been deprecated.
By doing this we can also let user to take advantage of the new advanced functionality
connector
.I also modify the spanmetric dashboard to be compatible with breaking changes from the spanmetrics connector, which are listed in (here)[Compatibility with important changes to the Spanmetrics connector
]
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions