rename proto package from hipstershop to oteldemo #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jack-berg,
mateuszrzeszutek and
trask
|
We'll need a changelog entry too. Thanks for doing this @codeboten |
Wanted to see how much work was involved here, open to alternative names. Figured oteldemo was short and to the point :) Fixes open-telemetry#638 Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rename-hipstershop
branch
from
99e2a38 to
2d0a369
Compare
|
Updated the changelog, although i found it confusing that the changelog doesn't match w/ the release notes. I added headers to separate the released versions from what wasn't released. Tested this locally, looks good 👍🏻 |
There was a problem hiding this comment.
It looks great!
Thx for taking care of this @codeboten!
I haven't approved bc I couldn't test (currently on my phone), but will build and run it later.
Also, thx for the update on the changeling, it looks way more organised now!
julianocosta89
approved these changes
Feb 11, 2023
styblope
pushed a commit
to instana/opentelemetry-demo
that referenced
this pull request
Mar 12, 2023
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renames the proto definition package to oteldemo. Wanted to see how much work was involved here, open to alternative names. Figured oteldemo was short and to the point :)
Fixes #638
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.