Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[productcatalogservice]add basic metric support #674

Merged
merged 8 commits into from
Jan 11, 2023
Merged

[productcatalogservice]add basic metric support #674

merged 8 commits into from
Jan 11, 2023

Conversation

Frapschen
Copy link
Contributor

@Frapschen Frapschen commented Jan 9, 2023 •
edited
Loading

Changes

add basic metric support

image

related:#66

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Frapschen Frapschen requested a review from a team January 9, 2023 07:51
@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Jan 9, 2023 •
edited
Loading

docs/services/productcatalogservice.md should also be updated.

@julianocosta89
Copy link
Member

docs/services/productcatalogservice.md should also be updated.

https://github.com/open-telemetry/opentelemetry-demo/blob/main/docs/services/productcatalogservice.md#metrics

@Frapschen
Copy link
Contributor Author

@fatsheep9146 @julianocosta89 please review :)

julianocosta89
julianocosta89 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update the golang version and the go get command in order to be able to build the new container.
LGTM

@julianocosta89 julianocosta89 merged commit 6b2cd9e into open-telemetry:main Jan 11, 2023
@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label Jan 17, 2023
@Frapschen Frapschen deleted the productcatalogservice_meter branch April 28, 2023 06:29
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@Frapschen @fatsheep9146 @julianocosta89
[productcatalogservice]add basic metric support (open-telemetry#674)
b04eb89 
* add basic metric support

* fix lint

* fix lint

* fix lint

* Update productcatalogservice.md

* Update Dockerfile

Co-authored-by: Ziqi Zhao <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

Assignees
No one assigned
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Frapschen @fatsheep9146 @julianocosta89 @puckpuck