-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource detectors to cart service #663
Add resource detectors to cart service #663
Conversation
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out locally and nothing was added to the Resource Attributes. I suspect this is not working on my Ubuntu, because a similar issue happened when testing #662
Is it any specific version of docker required to this to work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my Windows and it worked.
Also using docker
Doesn't work for me when using docker desktop on mac. |
This is probably due to a Limitation because of cgroup v2, there is a solution in the making for dotnet: open-telemetry/opentelemetry-dotnet-contrib#839 Java & NodeJS have that fixed already. |
Thanks @svrnm. Lgtm and the dependency PR seems to be making progress. Merging. |
Changes
Resource detection for cart service, right now it is only the container.id because it looks like no other resource detectors exist for .NET (yet)
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions