shippingservice: add http client request span #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds new http client span for outgoing calls to `/getquote` endpoint of quoteservice via the `reqwests` client middleware instrumentation. This provides a bit of the server/client tasks separation visibility as well as enables span pairing with the downstream quoteservice server span. The instrumentation uses the available `reqwests-tracing` and `tracing-opentelementry` crates.
|
|
julianocosta89
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Thanks for the contribution @styblope!
A lot of new attributes and events were added automatically. Good one!
Could you also update the doc for the Shipping Service to reflect your changes?
https://github.com/open-telemetry/opentelemetry-demo/blob/main/docs/services/shippingservice.md
julianocosta89
approved these changes
Dec 1, 2022
|
Hey @GaryPWhite, as you were the main responsible for the |
GaryPWhite
approved these changes
Dec 2, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* shippingservice: Add http client request span The commit adds new http client span for outgoing calls to `/getquote` endpoint of quoteservice via the `reqwests` client middleware instrumentation. This provides a bit of the server/client tasks separation visibility as well as enables span pairing with the downstream quoteservice server span. The instrumentation uses the available `reqwests-tracing` and `tracing-opentelementry` crates. * update shippingservice docs * update changelog * update doc section position * apply syntax change suggestion Co-authored-by: Juliano Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I propose to add a dedicated http client span for the outgoing calls to
/getquote. This change will provide tracing separation between the server part and the downstream requests client part inside shippingservice. A client span can also better match with the peer quoteservice server span. The client middleware-based instrumentation uses the availablereqwests-tracingandtracing-opentelementrycrates.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions