Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductCatalogService Cleanup #317

Merged
merged 3 commits into from
Aug 18, 2022
Merged

ProductCatalogService Cleanup #317

merged 3 commits into from
Aug 18, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Aug 18, 2022

Fixes #288

Changes

  • Rename file to main.go, it used to be server.go (being consistent with checkoutservice)
  • Remove the live changing of the JSON products file
  • Remove artificial response time delay if enabled by an environment variable
  • Simplify logging
  • Make logging messages simpler and more consistent

For significant contributions please make sure you have completed the following items:

@mic-max mic-max marked this pull request as ready for review August 18, 2022 05:52
@mic-max mic-max requested a review from a team August 18, 2022 05:52
puckpuck
puckpuck approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Removing the additional complexity certainly helps people to focus on what matters for this service.

@cartersocha cartersocha merged commit 8fb48f3 into open-telemetry:main Aug 18, 2022
@mic-max mic-max deleted the product-clean branch August 18, 2022 18:02
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@mic-max
ProductCatalogService Cleanup (open-telemetry#317)
72c2936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mic-max @puckpuck @reyang @cartersocha