make span context management api public #966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 161 161
Lines 6780 6780
=======================================
Hits 6465 6465
Misses 315 315
|
ThomsonTan
reviewed
Sep 2, 2021
api/test/trace/span_benchmark.cc
Outdated
| @@ -112,7 +112,7 @@ void BM_SpanCreationWitContextPropagation(benchmark::State &state) | |||
| auto outer_span_context = SpanContext(trace_id, span_id, trace_api::TraceFlags(), false); | |||
| auto outer_span = | |||
| nostd::shared_ptr<trace_api::Span>(new trace_api::DefaultSpan(outer_span_context)); | |||
| trace_api::propagation::SetSpan(current_ctx, outer_span); | |||
| opentelemetry::trace::SetSpan(current_ctx, outer_span); | |||
There was a problem hiding this comment.
Probably just use trace_api as it is already used a lot?
ThomsonTan
reviewed
Sep 2, 2021
| @@ -6,7 +6,7 @@ | |||
| #include "tracer_common.h" | |||
| #include "opentelemetry/trace/span_context_kv_iterable_view.h" | |||
| #include "opentelemetry/trace/semantic_conventions.h" | |||
|
|
|||
| #include "opentelemetry/trace/context.h" | |||
There was a problem hiding this comment.
Fix order of header files?
|
@ThomsonTan - Thanks for reviewing the PR. I have fixed the comments. But had to raise new PR with all these changes( #966 ) as this PR has easycla issue with few commits. Please review that, it already has your suggested changes. |
|
closing this PR |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950
Changes
Move span-context helper methods from
trace::propagationtotracenamespace. They are now treated as being in public api namespace. It's not possible to move them to Span API ( i.e, making them static within api::Span class ) as the complete implementation ofDefaultSpanis not visible/available in that class.This is how header structure looks like:
context/context.h - contains implementation for context data-structure logic
trace/tracer.h - span context management ( implicit )
trace/context.h - span context management ( explicit )
The implicit context management are still static methods in
trace::tracerclass to ensure not to introduce a breaking change, and at the same time remain specs compliant.cc @jsuereth
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes