-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable bazel build for gcc 4.8, upgrade versions for grpc and bazel, document bazel support #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
Disable bazel build for gcc 4.8, upgrade versions for grpc, and bazel, document bazel support
Disable bazel build for gcc 4.8, upgrade versions for grpc and bazel, document bazel support
Aug 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 160 160
Lines 6780 6780
=======================================
Hits 6465 6465
Misses 315 315 |
jsuereth
approved these changes
Aug 19, 2021
.github/workflows/ci.yml
Outdated
run: ./ci/do_ci.sh bazel.legacy.test | ||
env: | ||
CC: /usr/bin/gcc-4.8 | ||
# bazel build is disabled for gcc 4.8 compiler as grpc lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say just remove this instead of comment. It's unlikely we can bring it back and of we need it it's in git history.
ThomsonTan
approved these changes
Aug 19, 2021
ThomsonTan
reviewed
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947
Changes
New versions:
grpc : 1.39.1
Bazel: 4.2.0
Bazelisk: 1.10.1
cc @jsuereth
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes