Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest grpc version (v1.39.0) for cmake build of otlp exporter. #927

Merged
merged 13 commits into from
Aug 2, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 28, 2021

Changes

  • Use the latest grpc version ( v1.39.0) for cmake builds of otlp exporter when compiled with g++5.1 or greater
  • Use the compatible grpc version (v1.33.2) for cmake builds of otlp exporter when compiled with g++4.8 or g++5.0 compiler.
  • Add github workflow to build otlp exporter using g++4.8 compiler ( with grpc v1.33.2 )
  • Install abseil C++ library - as grpc v1.39.0 service api has a dependency on this library ( and we use this for otlp mock)

we still need similar support for bazel. As of now, bazel builds uses grpc v1.33.2.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 28, 2021 13:35
@lalitb lalitb changed the title Use latest grpc version ( v1.39.0) for cmake build of otlp exporter. Use latest grpc version (v1.39.0) for cmake build of otlp exporter. Jul 28, 2021
@lalitb lalitb changed the title Use latest grpc version (v1.39.0) for cmake build of otlp exporter. Use (current) latest grpc version (v1.39.0) for cmake build of otlp exporter. Jul 28, 2021
@lalitb lalitb changed the title Use (current) latest grpc version (v1.39.0) for cmake build of otlp exporter. Use latest grpc version (v1.39.0) for cmake build of otlp exporter. Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #927 (90ecacf) into main (5067e49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #927   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6779     6779           
=======================================
  Hits         6464     6464           
  Misses        315      315           

"${SRC_DIR}"
grpc_cpp_plugin=`which grpc_cpp_plugin`
proto_make_file="CMakeFiles/opentelemetry_proto.dir/build.make"
sed -i "s~gRPC_CPP_PLUGIN_EXECUTABLE-NOTFOUND~$grpc_cpp_plugin~" ${proto_make_file} #fixme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually copied from here (existing otlp build action on ubuntu-latest):

sed -i "s~gRPC_CPP_PLUGIN_EXECUTABLE-NOTFOUND~$grpc_cpp_plugin~" ${proto_make_file} #fixme

Somehow, cmake is not able to find the grpc_cpp_plugin executable during configuration and so it has to be replaced manually in generated make file before doing the actual make.
I will debug this separately and fix in another PR.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 31, 2021

CLA Signed

The committers are authorized under a signed CLA.

@lalitb lalitb merged commit 03f9604 into open-telemetry:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants