Dockerfile for quick demo/troubleshooting purpose. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6229 6229
=======================================
Hits 5817 5817
Misses 412 412 |
ThomsonTan
reviewed
Jul 15, 2021
|
|
||
| #install thrift | ||
| ARG THRIFT_VERSION=0.14.1 | ||
| RUN apt-get install -y --no-install-recommends \ |
There was a problem hiding this comment.
Could we invoke the setup_* scripts to create the container instead of duplicating the preparation steps?
There was a problem hiding this comment.
Yes agree, this can be simplified. Will change it.
|
incorrectly closed by bot. |
|
Could we merge this as it is? |
I will fix it this week for comments, to be ready for merge. |
I think we are good to merge this. As discussed in the community meeting today, @esigo will be making further changes on this. |
ThomsonTan
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this Dockerfile for some time as an environment for quick troubleshooting and felt it would act as a good playground for new devs/users to quickly try out opentelemetry-cpp along with exporters ( OTLP, Jaeger, Zipkin)
Also, we can further explore if this can be integrated into CI/CD pipeline ( ie running workflows on docker container instead of directly on github hosted virtual machines)