Allow to build WITH_JAEGER in Visual Studio 2019 + CMake
#815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't build WITh_JAEGER on Windows because Thrift was not installed in Visual Studio 2019 and `tools/build.cmd` build
vcpkg installed Thrift points to .\thrift whereas thrift-gen expects path 1-level up
Install Thrift as it is required for Jaeger exporter
Codecov Report
@@ Coverage Diff @@
## main #815 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 153 153
Lines 6444 6444
=======================================
Hits 6198 6198
Misses 246 246 |
ThomsonTan
reviewed
Jun 2, 2021
ThomsonTan
reviewed
Jun 2, 2021
ThomsonTan
approved these changes
Jun 2, 2021
Add period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Can't build
WITH_JAEGERon Windows via Visual Studio 2019, and/or viatools/build.cmdChanges:
setup-buildtools.cmdCMakeLists.txtthrift/but the code also includesthrift/*.h, so we need to append a dir that's 1-level up to make thrift-gen happy.These changes allow to build
WITH_JAGERon Windows.UNRELATED ISSUE: Thrift is extremely bulky and requires Boost.. takes quite a bit of time to build.