-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain the logical reasoning behind local Abseil snapshot + namespace renaming #797
Conversation
…scribe the integration process
Fix header
Fix header
Adjust wording
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 95.48% 93.64% -1.84%
==========================================
Files 156 190 +34
Lines 6614 8953 +2339
==========================================
+ Hits 6315 8383 +2068
- Misses 299 570 +271
|
We seriously have to do something about
We may need to edit the associated GitHub action to avoid triggering red marks, and only treat it as optional, always pass showing the code coverage rate changes. Maybe there's an option to configure a min threshold that trips the failure, excluding anything that is under 1%. Also, perhaps, if the list of changed files covers only Markdown or in |
incorrectly closed by bot. |
No code changes.
This PR is a supplementary doc that explains the logical reasoning / merits of the process used to create / refresh the Abseil snapshot in PR #572
Since some changes were not trivial, a separate section is added to elaborate on these changes.
Hopefully we should not employ this (semi-manual) process too often.