-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding baggage implementation #676
Adding baggage implementation #676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 94.66% 94.76% +0.10%
==========================================
Files 208 210 +2
Lines 9407 9644 +237
==========================================
+ Hits 8905 9139 +234
- Misses 502 505 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Looks nicely done, have few comments.
} | ||
header_s.append(Encode(key)); | ||
header_s.push_back(kKeyValueSeparator); | ||
header_s.append(Encode(value)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we ensure not to encode metadata, as it may result in double encoding ( as we don't decode it in FromHeader() )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct. Will fix this issue. Missed this bug in testcases !
Update : fixed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from few nitpiks.
Fixes #79
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes