Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breathe needs to be initialized in parent sphinx project #606

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

pyohannes
Copy link
Contributor

Changes

This initialized the sphinx breathe extension also in the parent sphinx project. This makes sure that documentation for all classes and member methods is included in the generated documentation (#595 (comment)).

@pyohannes pyohannes requested a review from a team March 11, 2021 23:56
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #606 (8270d56) into main (9aba950) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   94.41%   94.40%   -0.02%     
==========================================
  Files         191      191              
  Lines        9066     9066              
==========================================
- Hits         8560     8559       -1     
- Misses        506      507       +1     
Impacted Files Coverage Δ
sdk/src/logs/batch_log_processor.cc 93.75% <0.00%> (-1.25%) ⬇️

@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Mar 12, 2021
@lalitb lalitb merged commit b80cc91 into open-telemetry:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants