-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TraceState implementation as per spec #551
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
925c6a3
fix trace state as per specs
lalitb 7f4ecfa
fix format
lalitb 8f7ba83
fix
lalitb 0751130
fix gcc4.8
lalitb 24b95b7
fix
lalitb c067b23
fix
lalitb ba4ded2
fix
lalitb 70a2a26
fix
lalitb 34e9759
fix
lalitb e6c1204
Update api/include/opentelemetry/trace/trace_state.h
lalitb 2b1be89
review comments
lalitb 0d23d00
Merge branch 'main' into tracestate-fix
lalitb 1a54cdc
Update api/include/opentelemetry/trace/trace_state.h
lalitb 47977cd
Update api/include/opentelemetry/trace/trace_state.h
lalitb f3da416
Update api/include/opentelemetry/trace/trace_state.h
lalitb cc41067
Update api/test/trace/trace_state_test.cc
lalitb 1c27314
review fix
lalitb 228f2a7
review fix
lalitb 9b60b48
fix
lalitb ce24183
fix
lalitb 65b81e5
fix
lalitb a03fe1b
fix
lalitb 7413c85
fix
lalitb 6acf4d6
Merge branch 'main' into tracestate-fix
lalitb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should preserve the ability to distinguish between an key not being specified and a key given but having an empty value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per w3c specs ( https://www.w3.org/TR/trace-context/#value) the value can't be empty string ( should have at-least one non-blank character ). This is validated before storing from header. But I don't have strong preference on this, we can switch back to earlier prototype if that's more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have made comments consistent with method prototype.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Your method signature is fine.