[TEST] Add multi-threaded metrics benchmarks: shared vs per-thread counter#3898
Merged
marcalff merged 6 commits intoopen-telemetry:mainfrom Mar 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 226 226
Lines 7200 7200
=======================================
Hits 6483 6483
Misses 717 717 🚀 New features to boost your workflow:
|
owent
approved these changes
Mar 4, 2026
marcalff
approved these changes
Mar 4, 2026
Merged
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The spinlock protecting the storage of an instrument could be a bottleneck if it is invoked from multiple threads. This PR adds two new benchmarks to compare the performance of shared vs per-thread counter instrument creation under concurrent workloads:
BM_MeasurementsThreadsShareCounterTest- 4 threads share a single DoubleCounter created before the threads start (baseline).BM_MeasurementsPerThreadCounterTest- 4 threads each create their own DoubleCounter with the same name but a unique description (encoding thread id), so they don't share underlying storage.Both new benchmarks are structurally identical (same thread count, measurement count, attributes, and Collect call) so their results are directly comparable.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes