Skip to content

[EXPORTERS] Remove prometheus timestamps#3895

Merged
marcalff merged 9 commits intoopen-telemetry:mainfrom
carlosroman:remove-prometheus-timestamps
Mar 18, 2026
Merged

[EXPORTERS] Remove prometheus timestamps#3895
marcalff merged 9 commits intoopen-telemetry:mainfrom
carlosroman:remove-prometheus-timestamps

Conversation

@carlosroman
Copy link
Copy Markdown
Contributor

@carlosroman carlosroman commented Mar 1, 2026

Fixes #2316

Changes

This returns the previous behavior from #2324 that was removed in #2213.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@carlosroman carlosroman marked this pull request as ready for review March 1, 2026 16:02
@carlosroman carlosroman requested a review from a team as a code owner March 1, 2026 16:02
@carlosroman carlosroman changed the title Remove prometheus timestamps [EXPORTERS] Remove prometheus timestamps Mar 1, 2026
@marcalff marcalff added the discuss To discuss in SIG meeting label Mar 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (86389bc) to head (76e70ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3895   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         226      226           
  Lines        7229     7229           
=======================================
  Hits         6510     6510           
  Misses        719      719           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Mar 9, 2026

@carlosroman - The PR looks good, however you need to fix the failing CI tests, and merge conflicts.

@carlosroman carlosroman force-pushed the remove-prometheus-timestamps branch from 2253c8e to 82d28e4 Compare March 10, 2026 14:08
@carlosroman
Copy link
Copy Markdown
Contributor Author

@carlosroman - The PR looks good, however you need to fix the failing CI tests, and merge conflicts.

Have applied some fixes to clean up the code. I think the rest of the errors were CI infra related. Will clean up the other PR (#3894) as well in case you want to use that one instead of this one.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Mar 18, 2026

Will clean up the other PR (#3894) as well in case you want to use that one instead of this one.

Yes, we should close #3894 in favor of this PR. Please resolve the merge conflict.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Marc Alff <marc.alff@free.fr>
@marcalff
Copy link
Copy Markdown
Member

I resolved the merge conflicts using the web interface, but it went poorly.

Now cleaned up manually.

Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to confirm in SIG meeting for merge.

@marcalff
Copy link
Copy Markdown
Member

@lalitb To confirm, ok to merge ?

@marcalff marcalff merged commit 61e550e into open-telemetry:main Mar 18, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss To discuss in SIG meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prometheus exporter should not set explicit timestamps

3 participants