[EXPORTERS] Remove prometheus timestamps#3895
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 226 226
Lines 7229 7229
=======================================
Hits 6510 6510
Misses 719 719 🚀 New features to boost your workflow:
|
|
@carlosroman - The PR looks good, however you need to fix the failing CI tests, and merge conflicts. |
2253c8e to
82d28e4
Compare
Have applied some fixes to clean up the code. I think the rest of the errors were CI infra related. Will clean up the other PR (#3894) as well in case you want to use that one instead of this one. |
Co-authored-by: Marc Alff <marc.alff@free.fr>
|
I resolved the merge conflicts using the web interface, but it went poorly. Now cleaned up manually. |
marcalff
left a comment
There was a problem hiding this comment.
LGTM, to confirm in SIG meeting for merge.
|
@lalitb To confirm, ok to merge ? |
Fixes #2316
Changes
This returns the previous behavior from #2324 that was removed in #2213.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes