[DOCS] Fix code sample for setting CustomLogHandler#3736
Merged
marcalff merged 2 commits intoopen-telemetry:mainfrom Nov 14, 2025
Merged
[DOCS] Fix code sample for setting CustomLogHandler#3736marcalff merged 2 commits intoopen-telemetry:mainfrom
CustomLogHandler#3736marcalff merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
==========================================
- Coverage 90.01% 90.00% -0.01%
==========================================
Files 225 225
Lines 7105 7105
==========================================
- Hits 6395 6394 -1
- Misses 710 711 +1 🚀 New features to boost your workflow:
|
Member
|
/easycla |
- Remove erroneous backslash escapes in pointers. - Pass `CustomLogHandler` instance as `shared_ptr`.
jgreitemann
force-pushed
the
docs-fix-customloghandler-code-sample
branch
from
b776ec5 to
c3eba99
Compare
Contributor
Author
|
Finally sorted out the CLA. Sorry for the delay. |
marcalff
added
documentation
marcalff
approved these changes
Nov 14, 2025
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the code sample for registering a
CustomLogHandlerimplementation on the Getting Started page:CustomLogHandlerinstance asshared_ptr.Creating this as a draft PR for now, as I need to sort out the CLA.
CHANGELOG.mdupdated for non-trivial changes