[CMAKE] upgrade cmake minimum version to 3.16#3599
Merged
marcalff merged 6 commits intoopen-telemetry:mainfrom Aug 22, 2025
Merged
[CMAKE] upgrade cmake minimum version to 3.16#3599marcalff merged 6 commits intoopen-telemetry:mainfrom
marcalff merged 6 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
+ Coverage 90.02% 90.03% +0.02%
==========================================
Files 220 220
Lines 7069 7069
==========================================
+ Hits 6363 6364 +1
+ Misses 706 705 -1 🚀 New features to boost your workflow:
|
ThomsonTan
reviewed
Aug 22, 2025
ThomsonTan
approved these changes
Aug 22, 2025
marcalff
reviewed
Aug 22, 2025
marcalff
reviewed
Aug 22, 2025
Member
marcalff
left a comment
There was a problem hiding this comment.
Looks ok overall, with some questions on remaining cmake policies.
Also, please add an "important changes" entry in CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3598
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes