[BUILD] Allow compilation with CXX26#3464
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
d3425b6 to
615dc71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3464 +/- ##
==========================================
+ Coverage 89.92% 89.95% +0.03%
==========================================
Files 219 219
Lines 7041 7041
==========================================
+ Hits 6331 6333 +2
+ Misses 710 708 -2 🚀 New features to boost your workflow:
|
615dc71 to
8270332
Compare
8270332 to
58aef09
Compare
|
/easycla |
|
Doing force pushes do not trigger the CI build, it is started manually by maintainers since you are a first time contributor. This is a github security feature. For the PR to be considered, please sign the CLA. |
|
@marcalff Yeah sorry for that, I was asking Vencislav to force-push to re-trigger the CLA check, I was unsure how this worked exactly, but we sorted that out internally with the manager of our corporate CLA. |
@Romain-Geissler-1A @vencislav-georgiev-1A Bonjour, I somehow suspected you two were related. What does To trigger the CLA check again, the way to do it is just add a comment with |
Actually I was in a bar with some Red Hat maintainers yesterday and they told us the same thing: "1A" isn't clear to anyone ! "1A" is the code in the travelling industry assigned to our employer "Amadeus". Our competitors are being assigned other similar code "1X" (see some example on this page: https://www.airkiosk.com/airxml/airxml-static.php?page=whatIsGds.html ). But only people in the travel industry knows what it means, so it is effectively quite unclear when we contribute to open source projects indeed. |
Thanks for the clarification. Definitively not a student in first year in France, getting an assignment to contribute to opensource then (some people do that). And thanks for the contribution. |
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution.
[BUILD] Allow compilation with CXX26 (open-telemetry#3464)
Changes
A trivial patch which allows opentelemetry to be built with CXX26.
I successfully compiled it locally with gcc (GCC) 15.1.1