Test building opentelemetry-cpp as shared libraries against shared protobuf and grpc libraries#3427
Closed
dbarker wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Conversation
…protobuf as shared libraries
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3427 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 212 212
Lines 6937 6937
=======================================
Hits 6246 6246
Misses 691 691 🚀 New features to boost your workflow:
|
3 tasks
Member
Author
|
Closing this as addressed by #3435 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #3405 - This draft PR is just to demonstrate the current state of building opentelemetry-cpp shared libraries against newer versions of protobuf and grpc.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes