Fix type_traits.h to address compiler warnings around using deprecated methods

[agrawroh]

Description

__has_trivial_copy has been deprecated in favor of __is_trivially_assignable. This is causing issues while bumping up the Open Telemetry dependency in Envoy from v1.29 => v1.20 [See This].

Changes

We have created a patch in Envoy and are trying to upstream the fixes to get a clean patch-free build.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: step-security-bot / name: StepSecurity Bot (1d8da44)

[netlify]

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name	Link
🔨 Latest commit	ad21e5c
🔍 Latest deploy log	https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/680dd296519aba000819c966

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (7801cd9) to head (ad21e5c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.02%     
==========================================
  Files         211      211              
  Lines        6832     6832              
==========================================
+ Hits         6126     6127       +1     
+ Misses        706      705       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[owent]

#3355 should already fix this problem.
Could you please try it?
__is_trivially_assignable is not available in some old toolchains which are maintained by community.

[agrawroh]

#3355 should already fix this problem. Could you please try it? __is_trivially_assignable is not available in some old toolchains which are maintained by community.

Thanks, @owent. Looks like the suggested patch fixes the issue so I'll close this PR.

[agrawroh]

@owent I spoke too soon. Looks like we are still seeing the same issue even with the suggested patch:

bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:145:73: error: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Werror,-Wdeprecated-builtins]
  145 |   static constexpr bool value = std::is_copy_constructible<T>::value && __has_trivial_copy(T);
      |                                                                         ^
bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:157:70: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins]
  157 |   static constexpr bool value = std::is_copy_assignable<T>::value && __has_trivial_assign(T);
      |                                                                      ^
2 errors generated.

[owent]

@owent I spoke too soon. Looks like we are still seeing the same issue even with the suggested patch:

bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:145:73: error: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Werror,-Wdeprecated-builtins]
  145 |   static constexpr bool value = std::is_copy_constructible<T>::value && __has_trivial_copy(T);
      |                                                                         ^
bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:157:70: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins]
  157 |   static constexpr bool value = std::is_copy_assignable<T>::value && __has_trivial_assign(T);
      |                                                                      ^
2 errors generated.

Sorry, there were some mistakes before, could you please try the latest version of #3355 ?

[agrawroh]

@owent I spoke too soon. Looks like we are still seeing the same issue even with the suggested patch:

bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:145:73: error: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Werror,-Wdeprecated-builtins]
  145 |   static constexpr bool value = std::is_copy_constructible<T>::value && __has_trivial_copy(T);
      |                                                                         ^
bazel-out/k8-opt/bin/external/io_opentelemetry_cpp/api/_virtual_includes/api/opentelemetry/nostd/type_traits.h:157:70: error: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Werror,-Wdeprecated-builtins]
  157 |   static constexpr bool value = std::is_copy_assignable<T>::value && __has_trivial_assign(T);
      |                                                                      ^
2 errors generated.

Sorry, there were some mistakes before, could you please try the latest version of #3355 ?

Yes, that worked. I'll close this one out. Thanks!