[CI] pin cmake in ci and devcontainer#3336
Merged
marcalff merged 3 commits intoopen-telemetry:mainfrom Apr 1, 2025
Merged
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3336 +/- ##
==========================================
- Coverage 89.52% 89.51% -0.01%
==========================================
Files 210 210
Lines 6526 6526
==========================================
- Hits 5842 5841 -1
- Misses 684 685 +1 🚀 New features to boost your workflow:
|
Member
Author
|
@marcalff this pr is an option to give more time for the cmake upgrade if needed. |
lalitb
approved these changes
Apr 1, 2025
ThomsonTan
approved these changes
Apr 1, 2025
marcalff
approved these changes
Apr 1, 2025
Member
marcalff
left a comment
There was a problem hiding this comment.
Ok as an intermediate fix:
- it touches only files used in CI, production code unchanged
- it restores CI to a working state after the CMake 4.0.0 forced upgrade
We will need later to support CMake 4.0.0
Member
|
@dbarker Thanks. Let's use this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin cmake to version 3.31.6 in ci
Changes
setup_cmake.shscript to remove the system installed cmake and install a specific version from env var CMAKE_VERSION that defaults to 3.31.6setup_cmake.ps1script for windows that does the sameFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes