[SDK] Use OPENTELEMETRY_EXPORT and static local variables#3314
Merged
marcalff merged 6 commits intoopen-telemetry:mainfrom Mar 24, 2025
Merged
[SDK] Use OPENTELEMETRY_EXPORT and static local variables#3314marcalff merged 6 commits intoopen-telemetry:mainfrom
marcalff merged 6 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3314 +/- ##
==========================================
+ Coverage 89.50% 89.52% +0.03%
==========================================
Files 210 210
Lines 6522 6526 +4
==========================================
+ Hits 5837 5842 +5
+ Misses 685 684 -1
🚀 New features to boost your workflow:
|
marcalff
approved these changes
Mar 22, 2025
owent
approved these changes
Mar 24, 2025
Member
owent
left a comment
There was a problem hiding this comment.
LGTM, but I think we can also export copy constructors and copy assignment operators to reduce dumplicated weak symbols.
Member
|
@psx95 We would like to invite you to become an opentelemetry-cpp approver, if you would like to become one. To do so, please file a PR similar to this one: |
Contributor
Author
Thanks Marc, I'd be happy to ! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3302
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes