Skip to content

[EXPORTER] Support exporting event_name using OTLP Exporter#3277

Merged
marcalff merged 2 commits intoopen-telemetry:mainfrom
perhapsmaple:otlp-log-event-name
Feb 16, 2025
Merged

[EXPORTER] Support exporting event_name using OTLP Exporter#3277
marcalff merged 2 commits intoopen-telemetry:mainfrom
perhapsmaple:otlp-log-event-name

Conversation

@perhapsmaple
Copy link
Copy Markdown
Contributor

Fixes #3201

Changes

OtlpLogRecordable now supports exporting EventId::name

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: Harish <140232061+perhapsmaple@users.noreply.github.com>
Signed-off-by: Harish <140232061+perhapsmaple@users.noreply.github.com>
@perhapsmaple perhapsmaple requested a review from a team as a code owner February 16, 2025 08:27
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 16, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ccd1a3d
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67b1a18482261b00082c0663

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (2fdc022) to head (ccd1a3d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3277   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772           

@marcalff marcalff changed the title Support exporting event_name using OTLP Exporter [EXPORTER] Support exporting event_name using OTLP Exporter Feb 16, 2025
Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 7f047d5 into open-telemetry:main Feb 16, 2025
@perhapsmaple perhapsmaple deleted the otlp-log-event-name branch February 16, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support exporting event_name using OTLP Exporter

3 participants