-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] bump prometheus to v1.3.0 #3122
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
==========================================
+ Coverage 87.12% 87.88% +0.76%
==========================================
Files 200 195 -5
Lines 6109 6137 +28
==========================================
+ Hits 5322 5393 +71
+ Misses 787 744 -43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the upgrade.
Totally optional, please consider to add a section in file
docs/maintaining-dependencies.md
as well, for prometheus-cpp.
@marcalff thanks, added a section in file |
markdown lint (tentative)
for future reference looks like this missed the MODULE.bazel file, but maybe it wasn't in the central registry at the time either, submitted: #3162 |
Fixes # (issue)
Changes
bumps prometheus from
1.2.4
tov1.3.0
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes