Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] bump prometheus to v1.3.0 #3122

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 5, 2024

Fixes # (issue)

Changes

bumps prometheus from 1.2.4 to v1.3.0.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team as a code owner November 5, 2024 11:10
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit c35b593
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/672bc3b5d267dd0008e73dd7

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (497eaf4) to head (42d4950).
Report is 154 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
+ Coverage   87.12%   87.88%   +0.76%     
==========================================
  Files         200      195       -5     
  Lines        6109     6137      +28     
==========================================
+ Hits         5322     5393      +71     
+ Misses        787      744      -43     

see 99 files with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the upgrade.

Totally optional, please consider to add a section in file
docs/maintaining-dependencies.md as well, for prometheus-cpp.

@esigo
Copy link
Member Author

esigo commented Nov 6, 2024

@marcalff thanks, added a section in file docs/maintaining-dependencies.md, for prometheus-cpp.

@marcalff marcalff changed the title bump prometheus to v1.3.0 [EXPORTER] bump prometheus to v1.3.0 Nov 6, 2024
@marcalff marcalff merged commit b0e8d7a into open-telemetry:main Nov 6, 2024
55 checks passed
@esigo esigo deleted the bump-prometheus-1.3.0 branch November 6, 2024 20:28
@keith
Copy link
Contributor

keith commented Nov 22, 2024

for future reference looks like this missed the MODULE.bazel file, but maybe it wasn't in the central registry at the time either, submitted: #3162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants