-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Comply with W3C Trace Context #3115
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
+ Coverage 87.12% 87.83% +0.72%
==========================================
Files 200 195 -5
Lines 6109 6138 +29
==========================================
+ Hits 5322 5391 +69
+ Misses 787 747 -40
|
3759a7c
to
39e58f1
Compare
39e58f1
to
06283f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Please check the PR comments, it seems entry for test_traceparent_header_name_valid_casing
is duplicated.
See also minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixes.
6cd196d
to
ebaaaf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit comments. Thanks for working on this.
716c5fa
to
bb5f91a
Compare
[API] Comply with W3C Trace Context (open-telemetry#3115)
Fixes #74
Changes
SPEC_LEVEL=1
.TraceContextTest
&AdvancedTest
.Details
The following lists shows all the failing tests. Checked box indicates that the changes in this PR have fixed the test.
Currently failing tests from TraceContextTest suite
Currently failing tests from AdvancedTest suite
NOTE: The tests above were part of test suites
TraceContextTest
&AdvancedTest
. These test suites Trace Context Level 1 support.Current Status
All tests now passing. Test suites ran -
TraceContextTest
&AdvancedTest
.Additional Tasks
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes