Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove aligned_storage from nostd #3112

Merged

Conversation

ColoredCarrot
Copy link
Contributor

Fixes #3111

Changes

Removes absl::aligned_storage, which uses std::aligned_storage, which was deprecated in C++23.

Abseil removed its aligned_storage in abseil/abseil-cpp@4213346

@ColoredCarrot ColoredCarrot requested a review from a team as a code owner October 25, 2024 10:52
Copy link

linux-foundation-easycla bot commented Oct 25, 2024

CLA Signed

  • ✅login: ColoredCarrot / (ff38672)

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ff38672
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/671b79b760318d00083ea6fb

std::aligned_storage was deprecated in C++23.
Abseil removed its aligned_storage in abseil/abseil-cpp@4213346
@ColoredCarrot ColoredCarrot force-pushed the 3111-remove-aligned-storage branch from f31dee8 to ff38672 Compare October 25, 2024 10:57
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (497eaf4) to head (ff38672).
Report is 148 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
+ Coverage   87.12%   87.91%   +0.79%     
==========================================
  Files         200      195       -5     
  Lines        6109     6133      +24     
==========================================
+ Hits         5322     5391      +69     
+ Misses        787      742      -45     

see 98 files with indirect coverage changes

@marcalff marcalff changed the title Fix #3111: Remove aligned_storage from nostd [BUILD] Remove aligned_storage from nostd Oct 25, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Oct 25, 2024
@marcalff
Copy link
Member

@ColoredCarrot

Thanks for the fix.
Please sign the EasyCLA, so this can be merged.

@ColoredCarrot
Copy link
Contributor Author

Thanks for the fix. Please sign the EasyCLA, so this can be merged.

Sure, should be good now.

@marcalff marcalff merged commit 2c912d5 into open-telemetry:main Oct 25, 2024
55 of 56 checks passed
@marcalff marcalff removed the pr:waiting-on-cla Waiting on CLA label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using C++23 builds with warning: std::aligned_storage is deprecated
3 participants