-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Remove aligned_storage from nostd #3112
[BUILD] Remove aligned_storage from nostd #3112
Conversation
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
std::aligned_storage was deprecated in C++23. Abseil removed its aligned_storage in abseil/abseil-cpp@4213346
f31dee8
to
ff38672
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3112 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the fix. |
Sure, should be good now. |
Fixes #3111
Changes
Removes
absl::aligned_storage
, which usesstd::aligned_storage
, which was deprecated in C++23.Abseil removed its
aligned_storage
in abseil/abseil-cpp@4213346