Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Fix linking order and gmock linking #3106

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

owent
Copy link
Member

@owent owent commented Oct 17, 2024

Fixes #3102

Changes

  • Change the link order of gtest

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner October 17, 2024 03:27
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit c776bc5
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67122a3855a20b0008c59e25

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (497eaf4) to head (c776bc5).
Report is 143 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
+ Coverage   87.12%   87.91%   +0.79%     
==========================================
  Files         200      195       -5     
  Lines        6109     6133      +24     
==========================================
+ Hits         5322     5391      +69     
+ Misses        787      742      -45     

see 98 files with indirect coverage changes

@marcalff
Copy link
Member

LGTM,

Waiting a bit, to give the issue reporter a chance to test and confirm the fix works.

Ok to merge after that.

@owent owent changed the title [WIP]Fix link order Fix linking order and gmock linking Oct 18, 2024
@marcalff marcalff changed the title Fix linking order and gmock linking [TEST] Fix linking order and gmock linking Oct 18, 2024
@owent
Copy link
Member Author

owent commented Oct 18, 2024

LGTM,

Waiting a bit, to give the issue reporter a chance to test and confirm the fix works.

Ok to merge after that.

It's tested now.

@marcalff marcalff merged commit 1185405 into open-telemetry:main Oct 18, 2024
56 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Oct 18, 2024
[TEST] Fix linking order and gmock linking (open-telemetry#3106)
@owent owent deleted the fix_link_order branch December 12, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build the tests with WITH_STL=CXX17
3 participants