Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Fix URL in ES exporter, fix ipv6 supporting for http client. #3081

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

owent
Copy link
Member

@owent owent commented Oct 7, 2024

Fixes #3079
Fixes #3073

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner October 7, 2024 02:56
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ef725c9
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67034dfbaf498d00081af20a

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (497eaf4) to head (ef725c9).
Report is 134 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3081      +/-   ##
==========================================
+ Coverage   87.12%   87.81%   +0.69%     
==========================================
  Files         200      195       -5     
  Lines        6109     5968     -141     
==========================================
- Hits         5322     5240      -82     
+ Misses        787      728      -59     
Files with missing lines Coverage Δ
...include/opentelemetry/ext/http/common/url_parser.h 95.00% <100.00%> (+3.00%) ⬆️

... and 124 files with indirect coverage changes

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the two fixes.

@marcalff marcalff merged commit 3910b04 into open-telemetry:main Oct 7, 2024
56 checks passed
@marcalff marcalff changed the title Fix URL in ES exporter, fix ipv6 supporting for http client. [EXPORTER] Fix URL in ES exporter, fix ipv6 supporting for http client. Oct 7, 2024
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Oct 7, 2024
Fix URL in ES exporter, fix ipv6 supporting for http client. (open-telemetry#3081)
@owent owent deleted the fix_http_url branch December 12, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticSearch http client URL is wrongly formated [EXPORTER] exporter endpoint doesn't support ipv6
3 participants