Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update otel-collector version #3067

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

fabriziomello
Copy link
Contributor

Looks like otel-collector equal or higher than 0.86.0 has the "debug" exporter.

@fabriziomello fabriziomello requested a review from a team as a code owner September 19, 2024 18:04
Copy link

linux-foundation-easycla bot commented Sep 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fabriziomello / name: Fabrízio de Royes Mello (5633006)

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 5633006
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/66ed552707179000080615f6

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (497eaf4) to head (5633006).
Report is 132 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
+ Coverage   87.12%   87.78%   +0.66%     
==========================================
  Files         200      195       -5     
  Lines        6109     5953     -156     
==========================================
- Hits         5322     5225      -97     
+ Misses        787      728      -59     

see 125 files with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks for the fix.

Please:

  • upgrade to the most recent opentelemetry-collector version
  • update file ci/do_ci.sh as well, it should fix recent benchmark failures.

Looks like otel-collector equal or higher than 0.86.0 has the "debug"
exporter.

So updated the README.md with the latest version of the otel-collector
(v0.109.0) and also the CI script.
@fabriziomello
Copy link
Contributor Author

Well spotted, thanks for the fix.

Please:

  • upgrade to the most recent opentelemetry-collector version
  • update file ci/do_ci.sh as well, it should fix recent benchmark failures.

Done!

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Update otel-collector version [CI] Update otel-collector version Sep 20, 2024
@marcalff marcalff merged commit 23818a7 into open-telemetry:main Sep 20, 2024
56 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants