Skip to content

Conversation

@nadiaciobanu
Copy link
Contributor

The link to otlp_exporter.h is broken in the current version of the README. Fix it to use the proper path.

@nadiaciobanu nadiaciobanu requested a review from a team August 26, 2020 23:30
@reyang
Copy link
Member

reyang commented Aug 26, 2020

Consider adding a sanity check job like this open-telemetry/opentelemetry-specification#742. This would help to capture all the broken links from markdown files.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         146      146           
  Lines        6610     6610           
=======================================
  Hits         6250     6250           
  Misses        360      360           

@nadiaciobanu
Copy link
Contributor Author

@reyang Maybe I can create an issue for this, and it can be tackled in the future?

@nadiaciobanu
Copy link
Contributor Author

Created an issue for adding a DocFX sanity check to the CI here: #304.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang merged commit b23a759 into open-telemetry:master Aug 27, 2020
@nadiaciobanu nadiaciobanu deleted the readme-fix branch August 27, 2020 21:56
@nadiaciobanu nadiaciobanu changed the title Fix broken link in OTLP exporter README Fix OTLP exporter README Aug 31, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…s-create-or-update-comment-digest

Update peter-evans/create-or-update-comment digest to 70cab58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants