Skip to content

Conversation

@jajanet
Copy link
Contributor

@jajanet jajanet commented Aug 20, 2020

  • Add usage instructions for Bazel, including how to run the example
  • Add TODO for making CMake instructions
  • Remove most of the zPages explanation, replacing it with a link to the zPages spec

@jajanet jajanet requested a review from a team August 20, 2020 16:28
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #288 into master will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   93.93%   94.43%   +0.49%     
==========================================
  Files         146      146              
  Lines        6564     6596      +32     
==========================================
+ Hits         6166     6229      +63     
+ Misses        398      367      -31     
Impacted Files Coverage Δ
.../opentelemetry/sdk/metrics/aggregator/aggregator.h 58.82% <100.00%> (+2.57%) ⬆️
...emetry/sdk/metrics/aggregator/counter_aggregator.h 96.15% <100.00%> (+0.32%) ⬆️
...elemetry/sdk/metrics/aggregator/exact_aggregator.h 97.56% <100.00%> (+0.12%) ⬆️
...elemetry/sdk/metrics/aggregator/gauge_aggregator.h 100.00% <100.00%> (ø)
...etry/sdk/metrics/aggregator/histogram_aggregator.h 96.55% <100.00%> (+0.12%) ⬆️
.../metrics/aggregator/min_max_sum_count_aggregator.h 100.00% <100.00%> (ø)
...lemetry/sdk/metrics/aggregator/sketch_aggregator.h 69.76% <100.00%> (+0.71%) ⬆️
...clude/opentelemetry/sdk/metrics/sync_instruments.h 94.77% <100.00%> (+23.78%) ⬆️
sdk/test/metrics/metric_instrument_test.cc 100.00% <100.00%> (ø)
... and 1 more

@jajanet jajanet changed the title [WIP] Add zPages usage instructions, remove unneeded details Add zPages usage instructions, remove unneeded details Aug 22, 2020
@jajanet jajanet mentioned this pull request Aug 22, 2020
jajanet added a commit to kmanghat/opentelemetry-cpp that referenced this pull request Aug 22, 2020
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Aug 24, 2020
@reyang reyang merged commit 3ab51c5 into open-telemetry:master Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…-20250512.x

chore(deps): update dependency abseil-cpp to v20250512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants