Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Add option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW #2714

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[BUILD] Add option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW #2714

merged 1 commit into from
Jun 21, 2024

Conversation

owent
Copy link
Member

@owent owent commented Jun 21, 2024

Fixes #2700

Changes

  • Make WITH_OTLP_GRPC_SSL_MTLS_PREVIEW cached

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 21, 2024 06:35
@marcalff marcalff changed the title Make WITH_OTLP_GRPC_SSL_MTLS_PREVIEW cached [BUILD] Add option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW Jun 21, 2024
marcalff
marcalff approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 086e94c into open-telemetry:main Jun 21, 2024
50 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
@owent owent deleted the make_more_cmake_variable_options_cached branch August 2, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUILD] Cmake option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW is hidden
2 participants
@owent @marcalff