-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code health] Remove Unicode Text from Source files #2707
Conversation
Signed-off-by: perhapsmaple <[email protected]>
Signed-off-by: perhapsmaple <[email protected]>
Signed-off-by: perhapsmaple <[email protected]>
For UTF-8 character still present, like in:
The offending source code is:
Instead of using the character
could the code be changed to use unicode escape sequences like \u00F6 instead, so all the code is UTF-8 clean. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
==========================================
+ Coverage 87.12% 87.67% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5853 -256
==========================================
- Hits 5322 5131 -191
+ Misses 787 722 -65
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
See comments, to also replace UTF-8 characters present in test files.
This will affect the build when compiling with unit tests, so it is desirable to also clean test code, even if used only optionally.
Signed-off-by: perhapsmaple <[email protected]>
... and of course my suggestion does not work for windows / msvc for some reason (CI failures), sorry about that. From what I could find, windows may need a A possible work around is to code the UTF-8 data instead : "\xC3\xB6", please try. If this still fails, don't waste time on it, and remove changes from the two test files, these will be fixed separately. Thanks |
Signed-off-by: perhapsmaple <[email protected]>
Signed-off-by: perhapsmaple <[email protected]>
Signed-off-by: perhapsmaple <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Fixes #2706
Changes
Removed Unicode characters from API headers and
opentracing-shim/src/span_shim.cc
.Escaped UTF-8 characters from test file data:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes