-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code health] include-what-you-use cleanup, part 2 #2704
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
+ Coverage 87.12% 87.67% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5855 -254
==========================================
- Hits 5322 5133 -189
+ Misses 787 722 -65
|
Marking as blocking, because this PR is likely to cause merge conflicts with the clang-tidy cleanup: so it is very desirable to get this merged soon. Also, merging this round (part 2) is required before implementing more include-what-you-use cleanup on more code. @open-telemetry/cpp-approvers Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Contributes to #2054
Changes
Changed the include-what-you-use build to:
Performed general cleanup to resolve issues reported by
include-what-you-use
:For the most part, applying the code suggestions from
include-what-you-use
was sufficient.In some cases, in particular for:
the namespace directive causes
iwyu
to want a header to declare thenostd
namespace itself.Because there are many available headers, iwyu does not suggest the best choice.
Resolved by removing the namespace alias, and use fully qualified names instead:
This is the second pass at cleanup, follow up work is still required.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes