Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix typo tace_id -> trace_id in logger.h #2703

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

yijiem
Copy link
Contributor

@yijiem yijiem commented Jun 17, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@yijiem yijiem requested a review from a team June 17, 2024 06:00
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (497eaf4) to head (262a7de).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
+ Coverage   87.12%   87.65%   +0.53%     
==========================================
  Files         200      190      -10     
  Lines        6109     5853     -256     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      723      -64     
Files Coverage Δ
api/include/opentelemetry/logs/logger.h 63.89% <ø> (-0.69%) ⬇️

... and 105 files with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title [doc] Fix typo tace_id -> trace_id in logger.h [DOC] Fix typo tace_id -> trace_id in logger.h Jun 17, 2024
@marcalff marcalff merged commit 05bfb8a into open-telemetry:main Jun 17, 2024
50 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jun 17, 2024
[DOC] Fix typo tace_id -> trace_id in logger.h (open-telemetry#2703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants