Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix Import Abseil-cpp #2701

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

LeiZhang-Hunter
Copy link
Contributor

…ink you can make a judgment when introducing abseil-cpp. If abseil is not introduced, then use find_package

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@LeiZhang-Hunter LeiZhang-Hunter requested a review from a team June 14, 2024 02:44
Copy link

linux-foundation-easycla bot commented Jun 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LeiZhang-Hunter / name: zhanglei (d6a678e)
  • ✅ login: marcalff / name: Marc Alff (7e11404)

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (7e11404).
Report is 80 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 79 files with indirect coverage changes

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI is failing for formatting, so need to be fixed before merging.

CMakeLists.txt Outdated Show resolved Hide resolved
…ink you can make a judgment when introducing abseil-cpp. If abseil is not introduced, then use find_package
@marcalff marcalff changed the title Fix Import Abseil-cpp [BUILD] Fix Import Abseil-cpp Jun 15, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit fad93f0 into open-telemetry:main Jun 15, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants