Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETW] Add table name mapping for Logs other than the default Log table #2691

Merged

Conversation

ThomsonTan
Copy link
Contributor

Fixes #2680, this is the option 1 in the proposal with minor extension on defining a mapping for the table names. This makes it more flexible for the SDK users for configure the table name in the ETW exporter, without changing the API call in the instrumented libraries.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (e0ed3eb).
Report is 73 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 73 files with indirect coverage changes

@ThomsonTan ThomsonTan marked this pull request as ready for review June 3, 2024 19:55
@ThomsonTan ThomsonTan requested a review from a team June 3, 2024 19:55
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments for perf. LGTM once resolved.

@ThomsonTan ThomsonTan merged commit cb9cd1d into open-telemetry:main Jun 5, 2024
50 checks passed
@ThomsonTan ThomsonTan deleted the ETW_exporter_table_name_mapping branch June 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Make table name configurable in OpenTelemetry C++ ETW exporter
2 participants