Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Return NoopLogRecord from NoopLogger #2668

Merged
merged 5 commits into from
May 16, 2024

Merge branch 'main' into fix_noop_logger_2656

75ec527
Select commit
Loading
Failed to load commit list.
Merged

[API] Return NoopLogRecord from NoopLogger #2668

Merge branch 'main' into fix_noop_logger_2656
75ec527
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2024 in 0s

87.59% (+0.47%) compared to 497eaf4

View this Pull Request on Codecov

87.59% (+0.47%) compared to 497eaf4

Details

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.59%. Comparing base (497eaf4) to head (75ec527).
Report is 63 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
+ Coverage   87.12%   87.59%   +0.47%     
==========================================
  Files         200      188      -12     
  Lines        6109     5847     -262     
==========================================
- Hits         5322     5121     -201     
+ Misses        787      726      -61     
Files Coverage Δ
api/include/opentelemetry/logs/event_logger.h 90.91% <ø> (-1.39%) ⬇️
api/include/opentelemetry/logs/logger.h 63.89% <ø> (-0.69%) ⬇️
sdk/src/logs/logger.cc 80.56% <ø> (+1.61%) ⬆️
api/include/opentelemetry/logs/noop.h 77.78% <64.29%> (-0.79%) ⬇️

... and 55 files with indirect coverage changes