-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API/SDK] Provider cleanup #2664
[API/SDK] Provider cleanup #2664
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
+ Coverage 87.12% 87.68% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5130 -192
+ Misses 787 721 -66
|
Good catch :) |
Waiting for the build to finish to make sure DLL links, then this will be ready for review. |
Add help-wanted label: The windows DLL build fails with undefined symbols, and I can not figure out why (I don't have windows locally to investigate). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Fixes #2506
Changes
Please provide a brief description of the changes here.
Flush()
andClose()
from theAPI
classopentelemetry::trace::Tracer
, starting with ABI version 2.XXXProviderFactory::Create()
methods to return anSDK
object instead of anAPI
object.Flush()
andShutdown()
.static_cast<SDK*>(API object)
from examples, and use cleaner code, to initialize SDK providers.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes