[BUILD] CMakeLists.txt: Enable CMAKE_MSVC_RUNTIME_LIBRARY support

[t-b]

The documentation for CMAKE_MSVC_RUNTIME_LIBRARY states 1:

This variable has effect only when policy CMP0091 is set to NEW prior to
the first project() or enable_language() command that enables a language
using a compiler targeting the MSVC ABI.

so the current usage of CMAKE_MSVC_RUNTIME_LIBRARY for vcpkg does not work at all.

Let's fix that by setting policy 91 to new if present.

[lalitb]

Sorry, removing the approval for the CI failure. Probably we should set the policy only if vcpkg is used (i.e, VCPKG_TOOLCHAIN is set)? cc @ThomsonTan

[t-b]

Sorry, removing the approval for the CI failure. Probably we should set the policy only if vcpkg is used (i.e, VCPKG_TOOLCHAIN is set)? cc @ThomsonTan

My usecase is not related to vcpkg, I'm just compiling with MSVC.

[marcalff]

Thanks for the PR.

This change is probably not sufficient, as it triggers build failures in CI.

Please investigate and fix errors such as:

benchmark.lib(benchmark.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MTd_StaticDebug' in attributes_hashmap_benchmark.obj [D:\a\opentelemetry-cpp\opentelemetry-cpp\build\sdk\test\metrics\attributes_hashmap_benchmark.vcxproj]

[t-b]

Thanks for the PR.

This change is probably not sufficient, as it triggers build failures in CI.

Please investigate and fix errors such as:

benchmark.lib(benchmark.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MTd_StaticDebug' in attributes_hashmap_benchmark.obj [D:\a\opentelemetry-cpp\opentelemetry-cpp\build\sdk\test\metrics\attributes_hashmap_benchmark.vcxproj]

Thanks for the review, will do.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (3ff8b97).
Report is 76 commits behind head on main.

❗ Current head 3ff8b97 differs from pull request most recent head 2566fa7

Please upload reports for the commit 2566fa7 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 74 files with indirect coverage changes

[ThomsonTan]

The CI should have been fixed by #2696.

[marcalff]

LGTM, thanks for the fix.