-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 #2633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks ok.
Please add a CHANGELOG entry to document the breaking change, as some semantic conventions declarations moved from sdk/resource to trace: the user code will need adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and merging.
Will write CHANGELOG entry as part of 1.15.0 release notes
[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 (open-telemetry#2633)
Fixes #2614 (issue)
Changes
upgrades semantic convention 1.25.0
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes