Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 #2633

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

esigo
Copy link
Member

@esigo esigo commented Apr 9, 2024

Fixes #2614 (issue)

Changes

upgrades semantic convention 1.25.0

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team April 9, 2024 15:49
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks ok.

Please add a CHANGELOG entry to document the breaking change, as some semantic conventions declarations moved from sdk/resource to trace: the user code will need adjustments.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merging.

Will write CHANGELOG entry as part of 1.15.0 release notes

@marcalff marcalff merged commit 8f15440 into open-telemetry:main Apr 16, 2024
48 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Apr 16, 2024
[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 (open-telemetry#2633)
@marcalff marcalff changed the title Upgrade to semantic convention 1.25.0 [SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to semantic convention 1.25.0
4 participants