Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add shellcheck --severity=error as a CI step #2618

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[CI] Add shellcheck --severity=error as a CI step #2618

merged 1 commit into from
Mar 28, 2024

Conversation

johnbley
Copy link
Member

Changes

Pass all .sh files through shellcheck --severity=error.

@johnbley johnbley requested a review from a team March 28, 2024 17:54
@marcalff
Copy link
Member

That was fast ;-)

Waiting for CI to complete.

marcalff
marcalff approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement in CI.

@marcalff marcalff changed the title [MISC] Add shellcheck --severity=error as a CI step [CI] Add shellcheck --severity=error as a CI step Mar 28, 2024
@marcalff marcalff merged commit 3adcc79 into open-telemetry:main Mar 28, 2024
48 checks passed
@johnbley johnbley deleted the shellcheck_ci branch March 29, 2024 00:39
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnbley @marcalff @ThomsonTan