Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Use set -e on all shell scripts and pass shellcheck --severity=error #2616

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

johnbley
Copy link
Member

Changes

Numerous shell scripts were not using set -e or equivalent. Additionally, make all scripts pass at least shellcheck --severity=error (basically just argument array quoting and exit values). I can add an additional PR for using shellcheck in CI.

@johnbley johnbley requested a review from a team March 28, 2024 16:55
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff changed the title Use set -e on all shell scripts and pass shellcheck --severity=error [MISC] Use set -e on all shell scripts and pass shellcheck --severity=error Mar 28, 2024
@marcalff marcalff merged commit a06fd25 into open-telemetry:main Mar 28, 2024
47 checks passed
@johnbley johnbley deleted the shellcheck_errors branch March 28, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants