Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] CMake cleanup for message() #2582

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[BUILD] CMake cleanup for message() #2582

merged 2 commits into from
Mar 8, 2024
+16 −15

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Mar 7, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

Inspected every message() from CMakeLists.txt
Added STATUS or FATAL_ERROR as appropriate.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team March 7, 2024 22:57
lalitb
lalitb approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

esigo
esigo approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks:)

@marcalff marcalff merged commit ac7ee5f into open-telemetry:main Mar 8, 2024
47 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
@marcalff marcalff deleted the fix_cmake_message branch June 3, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalff @lalitb @esigo