-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Support URL-encoded values for OTEL_EXPORTER_OTLP_HEADERS
#2579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Could we not rename url_parser.h to url_util.h ?
This will break user code, if there happens to be an include to url_parser.h, even when not used.
@marcalff Got it, I reverted the renaming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Support URL-encoded values for `OTEL_EXPORTER_OTLP_HEADERS` (open-telemetry#2579)
OTEL_EXPORTER_OTLP_HEADERS
OTEL_EXPORTER_OTLP_HEADERS
Fixes #2523
Changes
This PR adds support for URL-encoded values in
OTEL_EXPORTER_OTLP_HEADERS
and related headers, which is required by the specification.The necessary
url_decode
function is added toext/include/opentelemetry/ext/http/common/url_parser.h
, which was renamed toext/include/opentelemetry/ext/http/common/url_util.h
to reflect the change.For backwards compatibility, both URL-encoded and non-URL-encoded values are supported, for example:
CHANGELOG.md
updated for non-trivial changes